Phase I of #156633 Expose API for extensions to extend find/replace #156796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rebornix "Prevent yarn.lock changes in PRs" seems to be stuck, is that normal? |
SonOfLilit
added a commit
to SonOfLilit/kleenexp
that referenced
this pull request
Aug 2, 2022
|
@rebornix just making sure the CR is pending intentionally, and not just blocked by the "Prevent yarn.lock changes in PRs" action being stuck |
|
Should I keep maintaining this PR? Is it expected to be merged? |
|
Who is responsible for community approvals here? Hopefully there is a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #156633, and with the blessing of @rebornix , I introduce two parameters to the builtin command
editor.actions.findWithArgsthat together allow me to write an extension that implements search-as-you-type UX 95% similar to the Find Widget's. (The difference ismoveCursoronly happens when you first hit Return, vs. also if you start typing and then hit Esc. Otherwise I would advance to the next occurrence every time you type a character, and fixing that would be complex).Old screenshot, before the API change: