Refresh markdown preview when tab switch #166932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Dec 5, 2022
| // this will avoid the stale content when the preview is reactivated | ||
| // https://github.com/microsoft/vscode/issues/165188 | ||
| if (!e.webviewPanel.active) { | ||
| this.refresh(); |
There was a problem hiding this comment.
Not a fan of this approach as it results in extra rendering of the markdown
What about storing the current markdown inside the webview using setState?
There was a problem hiding this comment.
storing the current markdown inside the webview using setState
I tried but didn't figure out how to do it. The nearest thing I camp up is updating current webiview HTML(which does not avoid extra rendering of the markdown I guess):
const document = await vscode.workspace.openTextDocument(this._resource);
const content = await this._contentProvider.renderDocument(document, this, this._previewConfigurations, undefined, undefined, undefined, this._disposeCts.token);
this._webviewPanel.webview.html = content.html;Could you please elaborate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165188