Add configurable timeout for format on save #173382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #173381
This diff adds a configurable timeout for format on save. The default timeout is 3 seconds. If the format provider takes longer than this timeout, then the provider is canceled, the save proceeds, and the user is notified that the file was saved but may not be formatted due to a timeout.
To test this, set the timeout down low within the code (such as hardcode it to 100ms) and do a format on save. You should see the message. Note that the configuration shown to users is in seconds, so formatters may not timeout within 1sec.