Use C locale instead of en_US

[i-ky]

Not everybody speaks English and not everyone lives in the United States, so it is not given that en_US locale will be available on the system. C, however, must always be present on a (POSIX-compliant?) system, because it is selected as default on startup of the program, see https://man7.org/linux/man-pages/man3/setlocale.3.html The latter is therefore a much safer choice of a locale used to force English as output language, . as a decimal separator etc.

Resolves #189924.

[i-ky]

Note that there are a few more places that can potentially benefit from a similar change:

vscode/src/vs/base/node/ps.ts

Lines 228 to 229 in 362ac63

	// Set numeric locale to ensure '.' is used as the decimal separator
	exec(`${ps} ${args}`, { maxBuffer: 1000 * 1024, env: { LC_NUMERIC: 'en_US.UTF-8' } }, (err, stdout, stderr) => {

vscode/src/vs/platform/terminal/node/terminalProcess.ts

Line 594 in 362ac63

exec('lsof -OPln -p ' + this._ptyProcess.pid + ' | grep cwd', { env: { ...process.env, LANG: 'en_US.UTF-8' } }, (error, stdout, stderr) => {

vscode/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts

Lines 113 to 114 in 362ac63

	// Fallback to en_US if the locale is unknown
	return 'en_US.UTF-8';

[gone-for-coding]

@lszomoru do you mind having a look at this PR please? Thanks!

[mreduar]

Any update?

[AThomas62]

Will this get implemented? This issue breaks commits using pre-commit via vscode.

[mreduar]

Will this get implemented? This issue breaks commits using pre-commit via vscode.

Not yet

[AThomas62]

Will this get implemented? This issue breaks commits using pre-commit via vscode.

Not yet

Why, this is a small change?

[mreduar]

Will this get implemented? This issue breaks commits using pre-commit via vscode.

Not yet

Why, this is a small change?

Yes, but I don't know why it hasn't been mixed yet.