references-view: removeReferenceItem hotkey implementation #237486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
@jrieken Is there a time frame we can expect this PR to be reviewed within? |
|
@jrieken hiya. Is there something blocking this? Please let me know if I need to make any adjustments or do anything else. |
|
It has been over half a year since this PR was created. Is there any chance of it being reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #234017 and #200465.
Previously
removeReferenceItemdid not function when utilized via hotkey. This is because the function called by the hotkey does not have the "item" to remove.This is resolved by iterating over the current selection and calling remove on those items in the case where no item is provided.
This can be tested by: