Skip to content

Fix spurious detection of yarn #243250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix spurious detection of yarn #243250

wants to merge 7 commits into from

Conversation

rotu
Copy link

@rotu rotu commented Mar 11, 2025

Fixes #170101
Partial #193001

Previously, vscode could use find-yarn-workspace-root to identify that a package is using yarn as its package manager by looking for a package.json with the workspaces key. That is incorrect - npm and bun also use this key in their package manifest.

Now when running scripts from package.json in a multi-workspace package, it should default to npm. It should still use yarn if a yarn.lock file is detected.

@rotu
Copy link
Author

rotu commented Mar 12, 2025

@meganrogge Please let me know if you'd like me to update and/or rebase this branch for your review.

@rotu
Copy link
Author

rotu commented Mar 21, 2025

@meganrogge What's the next step here? It seems like the workflows have been stalled out for 10 days.

@evelant
Copy link

evelant commented Jun 1, 2025

This is quite frustrating. I use bun in a monorepo but can't run any of my scripts as build tasks in vscode because it keeps trying to use yarn or pnpm despite having packageManager specified to bun in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm.packageManager=auto incorrectly assumes yarn as package manager for running tasks
3 participants