extensionTipService does not find possible executables for nu, etc #246545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
commented
Apr 14, 2025
| @@ -148,6 +148,10 @@ export abstract class AbstractNativeExtensionTipsService extends ExtensionTipsSe | |||
| this.allOtherExecutableTips.set(key, { exeFriendlyName: exeBasedExtensionTip.friendlyName, windowsPath: exeBasedExtensionTip.windowsPath, recommendations: otherRecommendations }); | |||
| } | |||
| }); | |||
| console.log('these recommendations(both highImportanceRecommendations and mediumImportanceRecommendations) always seem to be empty: '); | |||
There was a problem hiding this comment.
I wish I can get these to show up in my dev tools!
I've set my log level to trace, did fresh build, but still cannot see any logs nor get the breakpoints to hit here.
Perhaps it has to do something with being abstract class constructor? I'm pretty lost.
There was a problem hiding this comment.
Use ILogService instead and you can see them in the shared log view
anthonykim1
commented
Apr 14, 2025
| } | ||
| } else { | ||
| exePaths.push(join('/usr/local/bin', exeName)); | ||
| exePaths.push(join('/usr/bin', exeName)); | ||
| exePaths.push(join(this.userHome.fsPath, exeName)); | ||
| // TODO: Should we look for </opt/homebrew/bin>? |
There was a problem hiding this comment.
Could not test this since executableTips were always empty for me
Same story with LOCALAPPDATA
There was a problem hiding this comment.
You have to copy exeBasedExtensionTips from product.json into product.overrides.json to get these populated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to figure out: #245698,
I noticed that there was already some logic where we search for executables and try to recommend appropriate extensions to install. I've noticed that I wasn't getting expected result (for example, nu language extension should've be suggested if nu executable was detected on my system).
It seems like in
vscode/src/vs/platform/extensionManagement/common/extensionTipsService.ts
Line 353 in c586d5c
I can't really test this change since:
getValidExecutableBasedExtensionTips) always seem empty for me.homebrew directory for Mac and LOCALAPPDATA for Windows.works since theexecutableTipswere always empty, andhighImportanceRecommendationsandmediumImportanceRecommendationsseemed to empty as well from the constructor.I tried to set bunch of logs, breakpoints but it seems like breakpoints inside the constructor of
AbstractNativeExtensionTipsServicenever hits and I can't get any of the console.logs to show up in my dev tools.Can I get some help? @sandy081