feat: conditionallyExecuteCommand API proposal #249742
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on @jrieken comment for allowing access to context through the API:
To implement this, I've added a new function to the
commands
API that allows conditional execution of commands based on the context of the active element. This could be a separate functionality from commands, but I figured it was better to add on to the existing commands implementation rather than creating an entirely new event registration system.Tests implemented in:
extensions/vscode-api-tests/src/singlefolder-tests/commands.test.ts
src/vs/workbench/api/test/browser/mainThreadCommands.test.ts
Closes #249741
Addresses common requests in #10471