Fix vscode.env.onDidChangeShell not firing in the webworker extension host

[jeanp413]

Fixes #249823

[jeanp413]

cc @meganrogge as it's terminal related 🙂

[bpasero]

I wonder how the one property can be different from the other 🤔

[jeanp413]

Good point, currently remoteAuthority is empty for the web worker extension host context

[jeanp413]

Seems that's intended for both webworker extension host and local extension host

vscode/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts

Line 46 in 91b48e2

public readonly remoteAuthority = null;

vscode/src/vs/workbench/services/extensions/electron-sandbox/localProcessExtensionHost.ts

Line 93 in 91b48e2

public readonly remoteAuthority = null;

[bpasero]

We have a bit more uses of IExtHostContext.remoteAuthority in the workbench and I wonder if these are all disfunct and should be using the environment service, do you want to adopt the others too?

[jeanp413]

I see some usage in MainThreadMcp.ts but I think it's fine in that case as it's related where mpc servers are executed