Skip to content

feat: use session token when syncing new profiles #249903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented May 27, 2025

This PR adds a session token so that the settings sync server can fetch a version of the data that is at least as up to date as the data associated with the session token.

Session token docs: https://learn.microsoft.com/en-us/azure/cosmos-db/consistency-levels#session-consistency

This PR is a draft PR for now because the server side has to be fully deployed first.

@rzhao271 rzhao271 requested a review from lszomoru May 27, 2025 16:11
@rzhao271 rzhao271 self-assigned this May 27, 2025
@rzhao271 rzhao271 requested a review from sandy081 May 27, 2025 16:11
@rzhao271 rzhao271 added this to the May 2025 milestone May 27, 2025
@lszomoru
Copy link
Member

Will defer to @sandy081 on this one as it is a client-side change.

@rzhao271 rzhao271 modified the milestones: May 2025, June 2025 May 29, 2025
@rzhao271 rzhao271 marked this pull request as ready for review June 17, 2025 21:52
@rzhao271
Copy link
Contributor Author

I'll test out this PR more tomorrow and then decide whether to merge it.
It seems the bug is still there even after deploying my latest server-side changes to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants