Implement MCP stdio shutdown spec compliance with graceful shutdown manager #250207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP stdio transport shutdown implementation was not following the MCP specification. Previously, it used
AbortController.abort()
to immediately terminate processes, but the spec requires a graceful shutdown sequence.Changes Made
Replaced the simple abort controller approach with a new
McpStdioConnectionManager
class that implements the exact shutdown sequence specified in the MCP specification:stdin.end()
to gracefully close communication with the server$stopMcp
called twice, immediately sends SIGKILLKey Features
taskkill
on Windows,process.kill
on POSIX systemsImplementation Details
The new
McpStdioConnectionManager
class:Before:
After:
This ensures MCP servers have proper opportunity to clean up resources and exit gracefully, improving reliability and following the established protocol specification.
Fixes #250206.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.