Skip to content

Fix translations for built-in extensions missing in remote mode #251252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 12, 2025

When using VS Code in remote mode with a non-English UI language, translations for built-in extensions (like Git source control) were missing and remained in English, while the rest of the UI was properly localized.

Root Cause

The issue had two main components:

  1. Missing NLS keys in remote builds: The nls.keys.json file wasn't included in the remote server build, preventing proper NLS (National Language Support) resolution for built-in extensions.

  2. UI language not propagated to backend: When scanning built-in extensions on the remote server, the current UI language wasn't being passed from the client, so the server couldn't load the appropriate translations.

Changes

1. Include NLS keys in remote server build

  • build/gulpfile.reh.js: Added 'out-build/nls.keys.json' to serverResourceIncludes to ensure NLS keys are available in remote builds

2. Fix NLS resolution logic

  • src/vs/base/node/nls.ts: Fixed the existence check to look for the actual language pack messages file instead of the cache directory, and reorganized Promise.all to avoid empty folder creation when keys file is missing

3. Propagate UI language through extension management chain

  • src/vs/platform/extensionManagement/common/extensionManagement.ts: Added optional language parameter to getInstalled method signature
  • src/vs/platform/extensionManagement/common/extensionManagementIpc.ts: Import platform language constant and pass it through IPC calls
  • src/vs/platform/extensionManagement/node/extensionManagementService.ts: Updated getInstalled and scanExtensions to accept and use the language parameter

The language now flows: Client → IPC → ExtensionManagementService → ExtensionsScanner → ExtensionsScannerService.scanAllExtensions → scanDefaultSystemExtensions(language)

Testing

All changes maintain backward compatibility with optional parameters and minimal modifications to existing interfaces.

Fixes #250579.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • electronjs.org
    • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Translations for built-in extensions are missing in remote mode Fix translations for built-in extensions missing in remote mode Jun 12, 2025
@Copilot Copilot AI requested a review from TylerLeonhardt June 12, 2025 04:04
Copilot finished work on behalf of TylerLeonhardt June 12, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations for built-in extensions are missing in remote mode
2 participants