Revert "Fix extraction of tab title name" #251379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab6d98e.
chrmarti
previously approved these changes
Jun 13, 2025
deepak1556
approved these changes
Jun 13, 2025
deepak1556
added a commit
that referenced
this pull request
Jun 16, 2025
This reverts commit 5d1bd8f. Reason for revert: Icon issue was side affect of the windows agent change that affected the rcedit binary which has now been addressed.
deepak1556
added a commit
that referenced
this pull request
Jun 18, 2025
This reverts commit 5d1bd8f. Reason for revert: Icon issue was side affect of the windows agent change that affected the rcedit binary which has now been addressed.
deepak1556
added a commit
that referenced
this pull request
Jun 18, 2025
* chore: bump gulp-electron@1.37.0 * chore: update package-lock.json * Reland "Fix extraction of tab title name" (#251379)" This reverts commit 5d1bd8f. Reason for revert: Icon issue was side affect of the windows agent change that affected the rcedit binary which has now been addressed. * chore: bump gulp-electron@1.37.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #250621
Fixes #251357