Fix "tool undefined completed" accessibility announcement in chat #251442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a chat tool completes but has no
confirmationMessages.title
, screen readers were announcing "Tool undefined completed" instead of providing meaningful information.Root Cause
The accessibility provider was attempting to access the
.value
property on an undefinedtitle
object:Solution
Added proper null checks and fallback logic to handle all title scenarios:
The fix now handles:
confirmationMessages
title
property.value
propertytoolId
when neededTesting
Added comprehensive test cases covering all scenarios to prevent regressions.
Fixes #251439.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.