Make sure handleCommandFinished is fired for PartialCommandDetectionCapability
#251655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to do/ defer: test |
Tyriar
reviewed
Jun 16, 2025
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Basicshell integration strategy is chosen due to either a screen reader being present when using pwsh (which lacks PSReadline support) or some other clashing configuration,partialCommandDetectionCapabilityvsCommandDetectionCapabilityis used.RunInTerminalToolrelies ononDidEndTerminalShellExecutionfiring in order to consider the terminal command running step completed. If that does not occur, the tool will continue to hang and wait for adoneevent that never comes.onDidEndTerminalShellExecutionwaits foronCommandFinishedto be fired from its capability. In the case of thepartialCommandDetectionCapability, that happens onlyonEnterIE when enter is sent to the terminal. That does not occur when the chat agent sends the command, so noonCommandFinishedgets fired and thus chat hangs and never believes the command has completed even though it has.The fix is to listen to
terminalInstance.onDidExecuteText.Repro I used to verify:
Enable NVDA on windows and screen reader mode. Set the default terminal profile to pwsh. Instruct chat agent to run
lsin the terminal. Watch it hang and never complete. Same steps using this PR allows it to complete, see screenshot below. Also verified this PR doesn't cause issues when not in screen reader mode. I believe this will fix other peoples' reports too, captured in other issues.fix #251436