Skip to content

fix a11y issues w chat diff buttons #251748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix a11y issues w chat diff buttons #251748

merged 1 commit into from
Jun 18, 2025
+18 −9

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 17, 2025 •
edited
Loading

  1. Make them keyboard focusable
  2. When focused, allow space or enter to open the file diff
  3. Set the proper role, button

fixes #250397
fixes #17563

demo.mov

@meganrogge meganrogge self-assigned this Jun 17, 2025
@meganrogge meganrogge added this to the June 2025 milestone Jun 17, 2025
@meganrogge meganrogge enabled auto-merge (squash) June 17, 2025 19:56
@meganrogge meganrogge merged commit 0e58f97 into main Jun 18, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/acc-diff-button branch June 18, 2025 18:46
hediet pushed a commit that referenced this pull request Jun 19, 2025
@meganrogge @hediet
fix a11y issues w chat diff buttons (#251748)
2576f17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

@roblourens roblourens Awaiting requested review from roblourens

@justschen justschen Awaiting requested review from justschen

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.

Diff tag are not reachable by keyboard
2 participants
@meganrogge @bpasero