auth - modernise local redirect page #251895
Merged
+67
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
commented
Jun 19, 2025
| @@ -33,90 +33,84 @@ body { | |||
| display: flex; | |||
| flex-direction: column; | |||
| color: var(--vscode-foreground); | |||
| font-family: "Segoe UI","Helvetica Neue","Helvetica",Arial,sans-serif; | |||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe WPC", "Segoe UI", system-ui, "Ubuntu", "Droid Sans", sans-serif; | |||
There was a problem hiding this comment.
this copies our VS Code fonts with fallbacks per platform, I did not understand why we had the font faces with external URLs, this feels better to me and matches what vscode does.
bpasero
commented
Jun 19, 2025
| } | ||
|
|
||
| body.error .message { | ||
| display: none; | ||
| @keyframes rise-and-glow { |
bpasero
commented
Jun 19, 2025
| <div class="container"> | ||
| <div class="content"> | ||
| <div class="icon-container"> | ||
| <img src="code-icon.svg" class="vscode-icon"> |
There was a problem hiding this comment.
This is no longer a link to our website, but I felt this was strange anyway?
TylerLeonhardt
approved these changes
Jun 19, 2025
hediet
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kapture.2025-06-19.at.16.31.30.mp4