Skip to content

Use a TestAuthUsageService for integration tests and clean up disposables a bit #251936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

TylerLeonhardt
Copy link
Member

The test service is needed because otherwise it creates an event that create a disposable... and the test itself doesn't clean that up properly.

That service isn't being tested here, so it's replaced with a mocked one.

…sables a bit

The test service is needed because otherwise it creates an event that create a disposable... and the test itself doesn't clean that up properly.

That service isn't being tested here, so it's replaced with a mocked one.
@TylerLeonhardt TylerLeonhardt self-assigned this Jun 19, 2025
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) June 19, 2025 18:11
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 19, 2025
bpasero
bpasero previously approved these changes Jun 19, 2025
@bpasero
Copy link
Member

bpasero commented Jun 19, 2025

@TylerLeonhardt oh, red CI

@TylerLeonhardt TylerLeonhardt merged commit 9489d85 into main Jun 19, 2025
8 checks passed
@TylerLeonhardt TylerLeonhardt deleted the tyler/stiff-firefly branch June 19, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants