Skip to content

make fig spec consistent with current code CLI #251945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025
Merged

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 19, 2025

fix #243808

This pull request enhances the extensions/terminal-suggest module by refining CLI options and subcommands in code.ts and updating corresponding tests in code.test.ts. Key changes include renaming arguments for clarity, adding new options, improving descriptions, and ensuring test coverage for all updates.

Added new CLI options:

--remove: Remove folder(s) from the last active window.
--add-mcp: Adds a Model Context Protocol server definition to the user profile.
--update-extensions: Update the installed extensions.
--disable-lcd-text: Disable LCD font rendering.
--disable-chromium-sandbox: Use this option for launching as sudo/elevated user.

Updated existing options:

--enable-proposed-api: Now supports variadic arguments (multiple extension IDs).
--log: Now supports multiple values (repeatable) and extension-specific log levels (e.g., publisher.name:logLevel).

Descriptions and argument handling:

Updated descriptions for new and existing options to match the latest VS Code CLI help output.
Ensured argument templates and suggestions are accurate for new options.

This enables #244294

@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 19, 2025
@meganrogge meganrogge requested a review from Tyriar June 19, 2025 20:24
@meganrogge meganrogge enabled auto-merge (squash) June 19, 2025 20:26
@meganrogge meganrogge marked this pull request as draft June 19, 2025 20:37
auto-merge was automatically disabled June 19, 2025 20:37

Pull request was converted to draft

@meganrogge meganrogge marked this pull request as ready for review June 19, 2025 20:37
@meganrogge meganrogge marked this pull request as draft June 19, 2025 20:41
@meganrogge meganrogge marked this pull request as ready for review June 19, 2025 20:44
@meganrogge meganrogge enabled auto-merge (squash) June 19, 2025 20:44
@meganrogge meganrogge merged commit 4d25f6a into main Jun 19, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/fig-spec branch June 19, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do consistency pass of code fig spec
2 participants