Allow tasks to be run via terminal suggest #252002

Copilot · 2025-06-20T16:41:17Z

This PR implements task completions in the terminal suggest widget, allowing users to type task names and run them directly from terminal suggestions.

Changes Made

Core Implementation

New Task Completion Provider: Created TaskCompletionProvider that implements ITerminalCompletionProvider to provide task suggestions based on user input
Task Execution Support: Extended ITerminalCompletion interface with command execution capability and modified SuggestAddon to execute tasks instead of inserting text
Smart Filtering: Tasks are filtered by:
- Task labels starting with user input (e.g., "build" matches "build task")
- Individual words in task labels (e.g., "build" matches "vs code build")
- npm script names in command arguments for better npm task discovery

User Experience

Proper Positioning: Tasks appear below other completion types but above file/folder suggestions as requested
Task Icons: Uses tools icon (🔧) for all task completions
Command Execution: When selected, tasks execute via workbench.action.tasks.runTask command rather than inserting text into terminal
Edge Cases: Handles tasks with spaces in labels and npm scripts correctly

Integration

Provider Registration: Registered as built-in provider in terminal suggest contributions
Configuration: Added builtinTasks to default enabled providers
Sorting Logic: Added task-specific sorting to position tasks appropriately in suggestion list

Example Usage

When a user types "build" in the terminal, they now see:

Selecting a task suggestion executes the task immediately instead of just inserting the task name.

Testing

Added comprehensive unit tests covering:

Task filtering by label and command arguments
Edge cases like tasks with spaces and npm scripts
Proper completion metadata (icons, details, commands)
Provider behavior with various input scenarios

Fixes #252001.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

electronjs.org
- Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Tyriar · 2025-06-20T19:22:39Z

src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionItem.ts

@@ -22,6 +22,7 @@ export enum TerminalCompletionItemKind {
 	// Kinds only for core
 	InlineSuggestion = 100,
 	InlineSuggestionAlwaysOnTop = 101,
+	Task = 102,


We want to support generic "VscodeCommand" kinds in the extension API too.

Changed from Task to VscodeCommand to support generic command kinds in the extension API. This makes the enum more generic and extensible for future command-based completions. Changes made in commit 76623a8.

Tyriar · 2025-06-20T19:23:25Z

src/vs/workbench/contrib/terminalContrib/suggest/common/terminalSuggestConfiguration.ts

@@ -80,6 +80,7 @@ export const terminalSuggestConfiguration: IStringDictionary<IConfigurationPrope
 			'terminal-suggest': true,
 			'pwsh-shell-integration': true,
 			'lsp': true,
+			'builtinTasks': true,


This should just be 'tasks'

Changed from 'builtinTasks' to 'tasks' in the default configuration. Updated in commit 76623a8.

Tyriar · 2025-06-20T19:27:15Z

src/vs/workbench/contrib/terminalContrib/suggest/browser/taskCompletionProvider.ts

+import { ThemeIcon } from '../../../../../base/common/themables.js';
+import { Codicon } from '../../../../../base/common/codicons.js';
+
+export class TaskCompletionProvider implements ITerminalCompletionProvider {


Could we move all the task completion provider into a new terminalContrib/task/ folder? Make sure the new terminal contrib is included in src\vs\workbench\contrib\terminal\terminal.all.ts. Follow these principles:

terminalContrib/suggest/ should know about command-based completions

terminalContrib/task/ should know about tasks and provide command-based completions to terminalContrib/suggest/

Moved the task completion provider to new terminalContrib/task/ folder structure following the requested architecture:

terminalContrib/suggest/ now knows about command-based completions via VscodeCommand kind

terminalContrib/task/ provides command-based completions to suggest

Added the new terminal contrib to terminal.all.ts

Updated all import paths and references
Changes implemented in commit 76623a8.

…lder, change config key Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Tyriar · 2025-06-20T20:53:08Z

src/vs/workbench/contrib/terminalContrib/task/browser/taskCompletionProvider.ts

+		// Get the text up to the cursor position
+		const prefix = value.substring(0, cursorPosition);
+		const words = prefix.trim().split(/\s+/);
+
+		// Only suggest tasks if we're at the beginning of a command or it's a single word
+		// This prevents tasks from appearing in the middle of complex commands
+		if (words.length > 1 && prefix.trim() !== words[0]) {
+			return [];
+		}


No filtering here is needed, that's handled by the suggest code

Removed the complex filtering logic in provideCompletions method as requested. The terminal suggest system now handles all the filtering automatically. Changes implemented in commit 529ae9d.

Tyriar · 2025-06-20T20:54:37Z

src/vs/workbench/contrib/terminalContrib/task/browser/taskCompletionProvider.ts

+		// Only suggest tasks if we're at the beginning of a command or it's a single word
+		// This prevents tasks from appearing in the middle of complex commands
+		if (words.length > 1 && prefix.trim() !== words[0]) {
+			return [];
+		}
+
+		const currentWord = words[words.length - 1] || '';


This and _shouldIncludeTask should actually do very little filtering. In general the suggestion should be provided when either:

There are no spaces in value

The words before cursorPosition (except the word that the cursor is on) match the text of the task exactly. For example "VS Code" and then the cursor position, should include all tasks with labels that start with "VS Code"

Simplified the filtering logic in _shouldIncludeTask as requested. Now it only does minimal filtering:

Shows all tasks when there are no spaces in the input

For multi-word input, only shows tasks where the preceding words match the task label exactly (e.g., "VS Code" cursor position shows tasks starting with "VS Code")

Updated the corresponding tests to match the new behavior. Changes in commit 529ae9d.

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Copilot · 2025-06-20T21:09:02Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

electronjs.org
- Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

Initial plan for issue

68d3c71

Copilot AI assigned Copilot and Tyriar Jun 20, 2025

Copilot started work on behalf of Tyriar June 20, 2025 16:41 View session

Copilot AI and others added 4 commits June 20, 2025 16:58

Add task completion provider for terminal suggest

90ed9ef

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Implement task execution for terminal suggest completions

526544f

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Add tests and improve task completion filtering

d42a72c

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Add task completion sorting and default configuration

36eb19f

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Allow tasks to be run via terminal suggest~~ Allow tasks to be run via terminal suggest Jun 20, 2025

Copilot AI requested a review from Tyriar June 20, 2025 17:09

Copilot finished work on behalf of Tyriar June 20, 2025 17:09

Tyriar requested changes Jun 20, 2025

View reviewed changes

Copilot started work on behalf of Tyriar June 20, 2025 19:27 View session

Refactor task completion: use VscodeCommand kind, move to separate fo…

76623a8

…lder, change config key Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Copilot finished work on behalf of Tyriar June 20, 2025 19:39

Copilot AI requested a review from Tyriar June 20, 2025 19:39

Get it kind of working

230c941

Tyriar requested changes Jun 20, 2025

View reviewed changes

Copilot started work on behalf of Tyriar June 20, 2025 20:56 View session

Simplify task completion provider filtering logic based on feedback

529ae9d

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>

Copilot AI requested a review from Tyriar June 20, 2025 21:09

Copilot finished work on behalf of Tyriar June 20, 2025 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow tasks to be run via terminal suggest #252002

Allow tasks to be run via terminal suggest #252002

Uh oh!

Copilot AI commented Jun 20, 2025 •

edited

Loading

Uh oh!

Tyriar Jun 20, 2025

Uh oh!

Copilot AI Jun 20, 2025

Uh oh!

Tyriar Jun 20, 2025

Uh oh!

Copilot AI Jun 20, 2025

Uh oh!

Tyriar Jun 20, 2025

Uh oh!

Copilot AI Jun 20, 2025

Uh oh!

Tyriar Jun 20, 2025

Uh oh!

Copilot AI Jun 20, 2025

Uh oh!

Tyriar Jun 20, 2025

Uh oh!

Copilot AI Jun 20, 2025

Uh oh!

Copilot AI commented Jun 20, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Allow tasks to be run via terminal suggest #252002

Are you sure you want to change the base?

Allow tasks to be run via terminal suggest #252002

Uh oh!

Conversation

Copilot AI commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Core Implementation

User Experience

Integration

Example Usage

Testing

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Tyriar Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 20, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Copilot AI commented Jun 20, 2025 •

edited

Loading