-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Linkable chat prompts/instructions/modes using vscode:// links #252441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not thinking about a way to ask the user for confirmation? This seems to trigger a non-trivial action (other than for example the one I added to show the chat view).
Prior art for when we open files/folders:
vscode/src/vs/code/electron-main/app.ts
Lines 132 to 135 in f82b740
private static readonly SECURITY_PROTOCOL_HANDLING_CONFIRMATION_SETTING_KEY = { | |
[Schemas.file]: 'security.promptForLocalFileProtocolHandling' as const, | |
[Schemas.vscodeRemote]: 'security.promptForRemoteFileProtocolHandling' as const | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my comment.
Just read in chat that you indicate a prompt is shown where to put the file, can you share an example? And can the user cancel and no action is performed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a setting and name it similar to the existing ones we have, something like security.promptForPromptProtocolHandling
@bpasero Can we discuss this in a follow-up issue? |
Fixes https://github.com/microsoft/vscode-copilot/issues/12944