Skip to content

Linkable chat prompts/instructions/modes using vscode:// links #252441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 26, 2025

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jun 25, 2025

@aeschli aeschli self-assigned this Jun 25, 2025
@aeschli aeschli enabled auto-merge (squash) June 25, 2025 18:57
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 25, 2025
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not thinking about a way to ask the user for confirmation? This seems to trigger a non-trivial action (other than for example the one I added to show the chat view).

Prior art for when we open files/folders:

private static readonly SECURITY_PROTOCOL_HANDLING_CONFIRMATION_SETTING_KEY = {
[Schemas.file]: 'security.promptForLocalFileProtocolHandling' as const,
[Schemas.vscodeRemote]: 'security.promptForRemoteFileProtocolHandling' as const
};

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment.

@bpasero
Copy link
Member

bpasero commented Jun 25, 2025

Just read in chat that you indicate a prompt is shown where to put the file, can you share an example? And can the user cancel and no action is performed?

@aeschli
Copy link
Contributor Author

aeschli commented Jun 26, 2025

I added a confirmation dialog:
image

@lszomoru lszomoru requested a review from bpasero June 26, 2025 10:06
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a setting and name it similar to the existing ones we have, something like security.promptForPromptProtocolHandling

@aeschli
Copy link
Contributor Author

aeschli commented Jun 26, 2025

@bpasero Can we discuss this in a follow-up issue?
I don't think we need to hold up the PR for that. I'd like @digitarald to be able to try this out tomorrow if it works for our use case.

@aeschli aeschli merged commit be0a027 into main Jun 26, 2025
8 checks passed
@aeschli aeschli deleted the aeschli/monthly-snail branch June 26, 2025 18:22
@bpasero
Copy link
Member

bpasero commented Jun 26, 2025

@aeschli I opened #252530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants