Enforce best practice for package tags in manifests

[me-and]

Description of the new feature/enhancement

Enforce the defined tag best practice in manifest files defined at https://github.com/microsoft/winget-pkgs/blob/master/doc/manifest/schema/1.0.0/defaultLocale.md#tags, to wit, "present these terms in all lower case with hyphens rather than spaces."

Proposed technical implementation details (optional)

This would be a two-part job, and each part can be implemented independently:

• Update the CI validation scripts run over pull requests to reject PRs that use tags with upper-case characters and spaces.
• Write a utility script to find and replace existing tags that use spaces or upper-case characters with hyphens and lower-case characters.

I've not exhaustively checked the existing tags; it might be that we want some of them to be in upper case (perhaps proper nouns?). I could also believe this is inappropriate and/or confusing in some locales; I'm fairly confident it'd be safe for all en_* locales – so the vast majority of tags – but I could believe there are other locales where using hyphens instead of spaces and/or using exclusively lower-case characters would change meanings in a fundamental way.

[KaranKad]

I think we should also enforce License to be consistent, validation should check for these well known licenses.

Apache-2.0
BSD-2-Clause
BSD-3-Clause
Freeware
GPL-2.0
GPL-3.0
LGPL-2.0
LGPL-2.1
LGPL-3.0
MIT
MPL-2.0
Proprietary
Public Domain
Unlicense

Currently some applications with similar kind of licenses have GNU GPLv2, GNU General Public License v2.0 as their License which is not consistent. Further having consistent license will help with searching an application with specific license. eg - This command can be implemented in winget winget search MIT --license and applications with given license will appear in the list.

Once #18354 is implemented cleaning process might become easy. Related to #27411

[vedantmgoyal9]

We can implement these checks in the YamlCreate.ps1 script also. @Trenly

[jedieaston]

Some licensing logic would be nice. I brought it up last year but I never turned it into a real feature request.

[Trenly]

We can implement these checks in the YamlCreate.ps1 script also. @Trenly

I would suggest we wait until these changes make it into the manifest schema, if they will be put into the schema at all. We don't want to over-restrict if not necessary, and the implementation may require more thought than just "Make everything lowercase" or "Restrict it to this enum"

Given that winget core functionality should be determined by MSFT, it would follow that this form of validation should also be determined through them setting the requirements

[denelon]

This has come up again with some recent differences seen in various manifests. We are essentially following the same guidance Stack Overflow uses for tags. All lower case with hyphens instead of spaces (for U.S. English). Other locales may be a bit more complicated, and we're looking at the implications.