[Package Issue]: Nvidia.GeForceNow

[ETHREAL1]

Please confirm these before moving forward

• I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
• I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Running a "Winget upgrade --all" will constantly update Nvidia.GeForceNow.

In short, it always thinks there is an update and reinstalls.

Steps to reproduce

Have Nvidia.GeForceNow installed and run "winget upgrade --all"

Actual behavior

Nvidia.GeForceNow gets reinstalled each time "winget upgrade --all" is run as it thinks that version: 2.0.38.105 is what is installed with version: 2.0.38.121 being available.

Expected behavior

Nvidia.GeForceNow to only be updated if there is actually an update.

Environment

Windows Package Manager v1.2.10271
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1586
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs

WinGet-2022-03-30-13-46-01.186.log

[OfficialEsco]

Related #43752 (comment)

[OfficialEsco]

Can you please try winget upgrade Nvidia.GeForceNow --override "-upgrade"?

[ETHREAL1]

Related #43752 (comment)

Ah, I did a search in the issues section and did not find anything.
Something interestingly though using Revo uninstaller to nuke GFN and then reinstalling it with winget the issue goes away. So there is still an issue with updating from older versions but...

[OfficialEsco]

Related #43752 (comment)

Ah, I did a search in the issues section and did not find anything. Something interestingly though using Revo uninstaller to nuke GFN and then reinstalling it with winget the issue goes away. So there is still an issue with updating from older versions but...

Aaaaand i'm too late again, god dammit, keep the issue open, i need someone with a older version of GeForceNow to test with D:

This seems to be a issue with how GeforceNow updates, because i can still not replicate this on the same version, every value i change gets changed back after the update, BUT WHY DOES IT NOT DO IT WHEN ITS ACTUALLY A LOWER VERSION?

I just checked Chocolatey and they actually do something funky

$toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"

Get-ChocolateyWebFile 'Nvidia GeForce NOW' "$toolsDir\GeForceNOW-release.exe" -Url 'https://download.nvidia.com/gfnpc/GeForceNOW-release.exe' -Checksum '15732fc09b5bc83a0ff0fbb4bab56375660b749a7bc5bf76c0bc877b11a0b7c4' -ChecksumType 'sha256'
Get-ChocolateyUnzip "$toolsDir\GeForceNOW-release.exe" $toolsDir

Install-ChocolateyInstallPackage 'Nvidia GeForce NOW' 'exe' '' "$toolsDir\setup.exe"

$shimIgnores = @(
    "GeForceNOW-release.exe",
    "GeforceNOW\GeforceNow_Installer.exe",
    "GeforceNOW\CEF\GeForceNOWContainer.exe",
    "GeforceNOW\CEF\GeForceNOWReliabilityMonitor.exe",
    "GeforceNOW\CEF\GeForceNOWStreamer.exe",
    "NVI2\NVNetworkService.exe"
)

foreach ($ignore in $shimIgnores) {
    New-Item "$toolsDir\$ignore.ignore" -type file -force | out-null
}

This is how it looks when you run GeForceNOW-release.exe

This is how it looks when i run .\GeForceNOW-release\setup.exe

So maybe they noticed the issue and started to use the setup.exe because it works as expected?

@SpecterShell help, i'm not sure what i'm looking at

edit: valid switches seems to be

		<bool name="clean" property="CleanInstall"/>
		<bool name="prestage" property="PrestageInstall"/>
		<bool name="validate" property="ValidationInstall"/>
		<string name="validationFile" property="ValidationFile"/>
		<bool name="forcereboot" property="RebootRequired"/>
		<bool name="noreboot" property="IgnoreReboot"/>
		<bool name="k" property="RebootRequired"/>
		<bool name="n" property="IgnoreReboot"/>
		<bool name="passive" property="ProgressOnly"/>
		<bool name="noeula" property="SkipEula"/>
		<bool name="nofinish" property="SkipFinish"/>
		<bool name="ignorepnp" property="IgnorePnpFlag"/>
		<bool name="progresswitheula" property="ProgressWithEula"/>
		<bool name="s" property="SilentInstall" />
		<bool name="skipGFNLaunch" property="SkipMallLaunch" />
		<bool name="skipMallLaunch" property="SkipMallLaunch" />
		<bool name="launchStreamer" property="LaunchStreamer" />

And /uninstall

[ETHREAL1]

Related #43752 (comment)

Ah, I did a search in the issues section and did not find anything. Something interestingly though using Revo uninstaller to nuke GFN and then reinstalling it with winget the issue goes away. So there is still an issue with updating from older versions but...

Aaaaand i'm too late again, god dammit, keep the issue open, i need someone with a older version of GeForceNow to test with D:

This seems to be a issue with how GeforceNow updates, because i can still not replicate this on the same version, every value i change gets changed back after the update, BUT WHY DOES IT NOT DO IT WHEN ITS ACTUALLY A LOWER VERSION?

I just checked Chocolatey and they actually do something funky

$toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"

Get-ChocolateyWebFile 'Nvidia GeForce NOW' "$toolsDir\GeForceNOW-release.exe" -Url 'https://download.nvidia.com/gfnpc/GeForceNOW-release.exe' -Checksum '15732fc09b5bc83a0ff0fbb4bab56375660b749a7bc5bf76c0bc877b11a0b7c4' -ChecksumType 'sha256'
Get-ChocolateyUnzip "$toolsDir\GeForceNOW-release.exe" $toolsDir

Install-ChocolateyInstallPackage 'Nvidia GeForce NOW' 'exe' '' "$toolsDir\setup.exe"

$shimIgnores = @(
    "GeForceNOW-release.exe",
    "GeforceNOW\GeforceNow_Installer.exe",
    "GeforceNOW\CEF\GeForceNOWContainer.exe",
    "GeforceNOW\CEF\GeForceNOWReliabilityMonitor.exe",
    "GeforceNOW\CEF\GeForceNOWStreamer.exe",
    "NVI2\NVNetworkService.exe"
)

foreach ($ignore in $shimIgnores) {
    New-Item "$toolsDir\$ignore.ignore" -type file -force | out-null
}

This is how it looks when you run GeForceNOW-release.exe This is how it looks when i run .\GeForceNOW-release\setup.exe So maybe they noticed the issue and started to use the setup.exe because it works as expected?

@SpecterShell help, i'm not sure what i'm looking at

edit: valid switches seems to be

		<bool name="clean" property="CleanInstall"/>
		<bool name="prestage" property="PrestageInstall"/>
		<bool name="validate" property="ValidationInstall"/>
		<string name="validationFile" property="ValidationFile"/>
		<bool name="forcereboot" property="RebootRequired"/>
		<bool name="noreboot" property="IgnoreReboot"/>
		<bool name="k" property="RebootRequired"/>
		<bool name="n" property="IgnoreReboot"/>
		<bool name="passive" property="ProgressOnly"/>
		<bool name="noeula" property="SkipEula"/>
		<bool name="nofinish" property="SkipFinish"/>
		<bool name="ignorepnp" property="IgnorePnpFlag"/>
		<bool name="progresswitheula" property="ProgressWithEula"/>
		<bool name="s" property="SilentInstall" />
		<bool name="skipGFNLaunch" property="SkipMallLaunch" />
		<bool name="skipMallLaunch" property="SkipMallLaunch" />
		<bool name="launchStreamer" property="LaunchStreamer" />

And /uninstall

Sorry.... if you had just said in the original reply.... with that said there is another development. The install performed by winget does not seem to actually be happening. after the "install" it does not show in the programs list. both from winget and windows.

[ETHREAL1]

hum...

`C:\Windows\system32>winget install "Nvidia.GeforceNow"
Found NVIDIA GeForce NOW [Nvidia.GeForceNow] Version 2.0.38.121
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.nvidia.com/gfnpc/GeForceNOW-release.exe
██████████████████████████████ 139 MB / 139 MB
Successfully verified installer hash
Starting package install...
Successfully installed

C:\Windows\system32>winget list "Nvidia.GeforceNow"
No installed package found matching input criteria.

C:\Windows\system32>`

[OfficialEsco]

No idea whats going on

PS M:\> winget install "Nvidia.GeforceNow"
Found NVIDIA GeForce NOW [Nvidia.GeForceNow] Version 2.0.38.121
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.nvidia.com/gfnpc/GeForceNOW-release.exe
  ██████████████████████████████   139 MB /  139 MB
Successfully verified installer hash
Starting package install...
Successfully installed

PS M:\> winget list "Nvidia.GeforceNow"
Name               Id                Version
-----------------------------------------------
NVIDIA GeForce NOW Nvidia.GeForceNow 2.0.38.121

Try winget install Nvidia.GeforceNow --override "/clean /skipGFNLaunch"

[ETHREAL1]

No idea whats going on

PS M:\> winget install "Nvidia.GeforceNow"
Found NVIDIA GeForce NOW [Nvidia.GeForceNow] Version 2.0.38.121
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.nvidia.com/gfnpc/GeForceNOW-release.exe
  ██████████████████████████████   139 MB /  139 MB
Successfully verified installer hash
Starting package install...
Successfully installed

PS M:\> winget list "Nvidia.GeforceNow"
Name               Id                Version
-----------------------------------------------
NVIDIA GeForce NOW Nvidia.GeForceNow 2.0.38.121

Try winget install Nvidia.GeforceNow --override "/clean /skipGFNLaunch"

Nope, still does not show as installed. I do have an old .exe installer but it appears to just grab the latest from NV. But when using that this does install unlike winget...

[SpecterShell]

The update API of GFN is https://ota.nvidia.com/release/available?product=GFN-win&version=2.0.30.112&channel=OFFICIAL , which returns the static link of the installer.
When the request version is lower than min_base_version, it will return an older one.

GeForce Now 2.0.30.112: https://ota-downloads.nvidia.com/ota/GeForceNOW-release_D593B4.exe

You can pass the -log:<LOGPATH> switch to the installer to see what goes wrong. (Change LOGPATH to wherever you want the log to be generated)

[OfficialEsco]

Upgrade still succeeded from 2.0.30.112 to 2.0.38.121, maybe the issue is between min_base_version and max_base_version?

[OfficialEsco]

InstallerSwitches updated in #56328

winget-pkgs/manifests/n/Nvidia/GeForceNow/2.0.38.121/Nvidia.GeForceNow.installer.yaml

Lines 15 to 19 in 6260514

	InstallerSwitches:
	Silent: -s
	SilentWithProgress: -passive
	Log: -log:"<LOGPATH>"
	Custom: -skipGFNLaunch -n

For anyone with this issue in the future:
You will be able to find the logs at %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir \WinGet-Nvidia.GeforceNow.<VersionNumber>-<InstallationDate>