Skip to content

Add policy rule for community contributions in fonts directory #262057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented May 31, 2025

@mdanish-kh mdanish-kh requested a review from denelon as a code owner May 31, 2025 08:54
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 31, 2025
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also need a rule under issueUpdated for synchronize events to cover the case where a PR is opened under manifests and then updated to point to fonts

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 31, 2025
@mdanish-kh
Copy link
Contributor Author

@Trenly - Can that be handled in the same rule with

        if:
          - payloadType: Pull_Request
          - isOpen
          - or:
              - isAction:
                  action: Opened
              - isAction:
                  action: Synchronize

similar to how this rule is defined? 🤔

- description: >-
When a PR is opened/updated, if no files are modified
* Close the issue
* Add a comment
if:
- payloadType: Pull_Request
- isOpen
- or:
- isAction:
action: Opened
- isAction:
action: Synchronize
- filesMatchPattern:
pattern: ^$

@mdanish-kh
Copy link
Contributor Author

I'm under the impression that isOpen does handle both open / updated cases tho

@Trenly
Copy link
Contributor

Trenly commented May 31, 2025

We can wait and test later I suppose; Its not super well documented

@denelon denelon merged commit fc54004 into microsoft:master Jun 3, 2025
3 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jun 3, 2025
@mdanish-kh mdanish-kh deleted the fonts-policy branch June 3, 2025 20:30
@mdanish-kh
Copy link
Contributor Author

Rule didn't work, was updated in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants