Skip to content

ktsu.blastmerge v1.0.11 #262069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matt-edmondson
Copy link
Contributor

@matt-edmondson matt-edmondson commented May 31, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


#262068

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-262069-20250531-1

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 31, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\ktsu.BlastMerge__DefaultSource\ktsu.BlastMerge.ConsoleApp.exe returned exit code: -532462766 Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\blastmerge.exe returned exit code: -532462766

Hex Dec Inverted Dec Symbol Description
E0434352 -532462766 3762504530 EXCEPTION_COMPLUS Unhandled Exception

(Automated response - build 1061.)

Copy link
Contributor

@Dvd-Znf Dvd-Znf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to remove the metadata/yaml language server comments

@Dvd-Znf
Copy link
Contributor

Dvd-Znf commented May 31, 2025

#262068

FYI: If you want to link a PR to an issue you need to prepend the issue id with a valid keyword in the PR's description
(Eg. Resolves #262068 instead of just #262068)

matt-edmondson and others added 2 commits June 1, 2025 08:49
Co-authored-by: Dvd-Znf <101937630+Dvd-Znf@users.noreply.github.com>
Co-authored-by: Dvd-Znf <101937630+Dvd-Znf@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-262069-20250531-2

Co-authored-by: Dvd-Znf <101937630+Dvd-Znf@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-262069-20250531-3

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-262069-20250531-4

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error Changes-Requested Changes Requested New-Package labels May 31, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 1, 2025
@matt-edmondson
Copy link
Contributor Author

Manual Validation ended with:
80070003 -2147024893 2147942403 COR_E_DIRECTORYNOTFOUND The specified path couldn't be found - ALLUSERSPROFILE Microsoft network dir doesn't exist

Attempted fix in HistoryInput.cs: ktsu-dev/BlastMerge@62289c0#diff-e05ca5db961f61bd2ea10956147d1b97935e4ec8f57e0ece7bdaca55c4a08401

Manual Validation ended with:

PS C:\Users\User\Desktop> C:\Users\User\AppData\Local\Microsoft\WinGet\Links\blastmerge.exe --version
CLR: Assert failure(PID 2672 [0x00000a70], Thread: 9064 [0x2368]): !AreShadowStacksEnabled() || UseSpecialUserModeApc()

Attempted fix in Program.cs: ktsu-dev/BlastMerge@62289c0#diff-e05ca5db961f61bd2ea10956147d1b97935e4ec8f57e0ece7bdaca55c4a08401

Tested with SandboxTest.ps1.

@matt-edmondson
Copy link
Contributor Author

Fixes "attempted" because I am unable to reproduce in both development and sandbox environment.

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 3, 2025
@Dragon1573
Copy link
Contributor

Hi @matt-edmondson, 👋🏼

Tip

It's recommended linking this PR to the issue using "close keywords".

Take care of those keywords because they're ONLY valid in your commit messages or PR descriptions. Editing your description is required. ❤️

@stephengillie
Copy link
Collaborator

stephengillie commented Jun 3, 2025

Manual Validation ended with:

PS C:\Users\User\Desktop> C:\Users\User\AppData\Local\Microsoft\WinGet\Links\blastmerge.exe --version
CLR: Assert failure(PID 4432 [0x00001150], Thread: 4940 [0x134c]): !AreShadowStacksEnabled() || UseSpecialUserModeApc()
File: D:\a_work\1\s\src\coreclr\vm\threads.cpp:7938 Image:
C:\Users\User\AppData\Local\Microsoft\WinGet\Links\blastmerge.exe
PS C:\Users\User\Desktop>

(Automated response - build 1061.)

Edit:
Hi @matt-edmondson,

Manual Validation ended with:

PS C:\Users\User\Desktop> C:\Users\User\AppData\Local\Microsoft\WinGet\Links\blastmerge.exe --version
CLR: Assert failure(PID 2672 [0x00000a70], Thread: 9064 [0x2368]): !AreShadowStacksEnabled() || UseSpecialUserModeApc()

Attempted fix in Program.cs: ktsu-dev/BlastMerge@62289c0#diff-e05ca5db961f61bd2ea10956147d1b97935e4ec8f57e0ece7bdaca55c4a08401

Does this package happen to use a .NET 9.0 framework/runtime? The message AreShadowStacksEnabled() appeared in another PR, related to that dependency.

Tested with SandboxTest.ps1.

I'm testing these in a Hyper-V VM downloaded with Quick Create. I believe the sandbox might leverage the host OS frameworks and runtimes, but I'm not sure. (I don't actually have the sandbox set up on my laptop, and instead run everything through my VM automation amd orchestration system.)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jun 3, 2025
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-63-262069-20250604-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed labels Jun 4, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 4, 2025
@matt-edmondson
Copy link
Contributor Author

Does this package happen to use a .NET 9.0 framework/runtime? The message AreShadowStacksEnabled() appeared in another PR, related to that dependency.

Yes it uses .NET 9. is there anything the other application had to change, or is it a validation issue?

@stephengillie
Copy link
Collaborator

Does this package happen to use a .NET 9.0 framework/runtime? The message AreShadowStacksEnabled() appeared in another PR, related to that dependency.

Yes it uses .NET 9. is there anything the other application had to change, or is it a validation issue?

Apologies - I didn't notice that it's already listed as a dependency. Are you seeing this error locally? If not, it might be an artifact of the validation environment.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jun 5, 2025
@matt-edmondson
Copy link
Contributor Author

Apologies - I didn't notice that it's already listed as a dependency. Are you seeing this error locally? If not, it might be an artifact of the validation environment.

@stephengillie I havent seen this error in my testing in my dev environment, my spare pcs, or windows sandbox.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 5, 2025
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jun 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 088690a into microsoft:master Jun 7, 2025
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 7, 2025
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants