Skip to content

fix: unexport CodecovConfig struct #40790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sambhav800
Copy link

Description

This PR unexports the CodecovConfig struct from cmd/codecovgen/main.go by changing its name from CodecovConfig to codecovConfig.

This change aligns with Go's convention of using unexported (lowercase) struct names when they are not used outside the local package. This also matches the intention described in issue #40641.

Link to tracking issue

Fixes #40641

Testing

No functional logic has been changed, so existing tests (if any) should continue to pass.

Documentation

Not applicable — this is a small internal visibility change with no impact on external documentation.

@Sambhav800
Copy link
Author

Hi @edmocosta, @songy23, and @mwear 👋

Thanks for your earlier feedback 🙏 I’ve corrected the PR by updating only the original main.go file in cmd/codecovgen, and unexported the CodecovConfig struct as per the issue #40641.

Please let me know if anything else needs to be improved — happy to make changes!

Thanks again for your time and review!

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 18, 2025
@@ -110,7 +110,7 @@ type ComponentManagement struct {
IndividualComponents []Component `json:"individual_components"`
}

type CodecovConfig struct {
type codecovConfig struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update the reference of it too

Copy link
Contributor

github-actions bot commented Jul 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 3, 2025
@atoulme atoulme marked this pull request as draft July 14, 2025 05:58
@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2025

Please address comment and failing CI and mark ready for review again

@github-actions github-actions bot removed the Stale label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/codecovgen Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexport structs
4 participants