Skip to content

[translator/faro] Add Timestamp, ObservedTimestamp, SpanId, and TraceId fields to Log Record #40800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Jun 18, 2025

Description

When converting telemetry data from Faro format into OTLP format, the fields Timestamp, ObservedTimestamp, SpanId, and TraceId were not set.
This PR aims to set those fields to the Log Record

Testing

Unit tests were updated

@@ -4,12 +4,13 @@
| Status | |
| ------------- |-----------|
| Stability | [alpha]: logs, traces |
| Distributions | [] |
| Distributions | [contrib] |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faroexporter and faroreceiver were added to the contrib distribution: open-telemetry/opentelemetry-collector-releases#955

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! created another PR: #40822

@mar4uk mar4uk force-pushed the faro-translator-add-missing-fields branch from e7f9028 to 1e14b49 Compare June 18, 2025 14:52
@mar4uk mar4uk marked this pull request as ready for review June 18, 2025 15:15
@mar4uk mar4uk requested review from a team and dehaansa as code owners June 18, 2025 15:15
@mar4uk mar4uk force-pushed the faro-translator-add-missing-fields branch from 0c5e3eb to c9bfac6 Compare June 19, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants