[receiver/libhoneyreceiver] remove unused EnvironmentInfo,AuthInfo,TeamInfo #40802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the CI. |
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
libhoneyreceiver_unexport
branch
from
f9af3bd to
24aa9b3
Compare
JaredTan95
changed the title
braydonk
approved these changes
Jun 19, 2025
| @@ -166,7 +139,7 @@ func (r *libhoneyReceiver) handleAuth(resp http.ResponseWriter, req *http.Reques | |||
| authURL := fmt.Sprintf("%s/1/auth", r.cfg.AuthAPI) | |||
| authReq, err := http.NewRequest(http.MethodGet, authURL, nil) | |||
| if err != nil { | |||
| errJSON, _ := json.Marshal(`{"error": "failed to create AuthInfo request"}`) | |||
| errJSON, _ := json.Marshal(`{"error": "failed to create authInfo request"}`) | |||
There was a problem hiding this comment.
nit: If this error is being returned to the client, should the word authInfo even be used? Makes it look like it's referring to something specific but it's just an auth endpoint request.
I know it's not the point of the PR so I don't consider it a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unused EnvironmentInfo,AuthInfo,TeamInfo
Link to tracking issue
Fixes #40669
Testing
Documentation