-
Notifications
You must be signed in to change notification settings - Fork 2.8k
kafkaexporter: Improve internal telemetry #40834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kafkaexporter: Improve internal telemetry #40834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few small things.
Maybe we should add exponential histogram support to mdatagen, and use that for measuring the latency. Not a blocker of course, just doesn't seem ideal to use explicit bounds.
I can raise an issue in opentelemetry-collector to add the support in mdatage and contribute the implementation. As this is not a blocker I will do this asynchronously. |
This is a problem we are running in to for other components as well, Worth raising it as a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the attribute duplication logic.
Description
This PR adds the following internal telemetry metrics to improve the exporter telemetry to make it easier to operate.
Click to expand
Link to tracking issue
Fixes
#40815
Testing
Unit tests are added, also tested manually.
Documentation
Documentation is autogenerated with mdatagen.