[CMAKE] Address the vcpkg opentelemetry-cpp port CMake patches #3518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argets. Test the opentracing-static target built with conan in ci
…chainload toolchain file
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3518 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.02%
==========================================
Files 219 219
Lines 7051 7051
==========================================
+ Hits 6342 6343 +1
+ Misses 709 708 -1 🚀 New features to boost your workflow:
|
dbarker
commented
Jul 5, 2025
| # Note: CMAKE_FIND_PACKAGE_PREFER_CONFIG requires cmake 3.15. Prefer cmake | ||
| # CONFIG search mode to find dependencies. This is important to properly find | ||
| # protobuf versions 3.22.0 and above due to the abseil-cpp dependency. | ||
| set(CMAKE_FIND_PACKAGE_PREFER_CONFIG TRUE) |
There was a problem hiding this comment.
We can remove this now that GTest, Protobuf, and gRPC are found with the CONFIG search mode explicitly.
marcalff
reviewed
Jul 7, 2025
ThomsonTan
reviewed
Jul 8, 2025
| @@ -497,6 +488,14 @@ if((NOT WITH_API_ONLY) AND USE_NLOHMANN_JSON) | |||
| include("${opentelemetry-cpp_SOURCE_DIR}/cmake/nlohmann-json.cmake") | |||
| endif() | |||
|
|
|||
| # | |||
| # Do we need OpenTracing ? | |||
There was a problem hiding this comment.
The official vcpkg port still supports it as opentelemetry-cpp[opentracing], but I think we could deprecate it, or plan on that.
ThomsonTan
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3401
Fix CMake issues requiring patches to the vcpkg opentelemetry-cpp port.
Changes
CMAKE_FIND_PACKAGE_PREFER_CONFIGVCPKG_CHAINLOAD_TOOLCHAIN_FILEFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes