-
Notifications
You must be signed in to change notification settings - Fork 485
[CMAKE] Add CMake script to find or fetch Microsoft.GSL #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcalff
merged 6 commits into
open-telemetry:main
from
dbarker:cmake_find_or_fetch_ms_gsl
Jul 10, 2025
Merged
[CMAKE] Add CMake script to find or fetch Microsoft.GSL #3521
marcalff
merged 6 commits into
open-telemetry:main
from
dbarker:cmake_find_or_fetch_ms_gsl
Jul 10, 2025
+61
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SL to the list of supported third party packages. Test WITH_GSL through the windows cmake.install.test
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 219 219
Lines 7051 7051
=======================================
Hits 6343 6343
Misses 708 708 🚀 New features to boost your workflow:
|
owent
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
ThomsonTan
reviewed
Jul 8, 2025
ThomsonTan
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes