[OpenTelemetry] Fix assertion failures in debug #6304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry
There was a problem hiding this comment.
Pull Request Overview
This PR fixes assertion failures in debug mode by skipping the metrics batch collection when the MeterProvider has not yet been initialized.
- Replaces Debug.Assert checks with a conditional null check
- Returns a default batch when required metrics are not set
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6304 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 258 258
Lines 11879 11881 +2
=======================================
+ Hits 10307 10309 +2
Misses 1572 1572
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@CodeBlanch Could you please review this PR? In my opinion |
martincostello
force-pushed
the
gh-6300
branch
4 times, most recently
from
3bfaae7 to
c07374d
Compare
Avoid failing assertions in debug by skipping collecting a metrics batch if the MeterProvider has not yet been initialized. Resolves open-telemetry#6300.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6300
Changes
Avoid failing assertions in debug by skipping collecting a metrics batch if the
MeterProviderhas not yet been initialized.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes