Skip to content

with_span doesn't call record_exception #236

Open
@garthk

Description

@garthk

I'd expect with_span to catch errors/exceptions, call record_exception, set the span status, and then re-raise like it did in OpenCensus.Elixir. I can't see it happening, though, nor find any mechanism for it.

In the OT world, adding events for exceptions is the default for Python, though they also provide record_exception and set_status_on_exception as start options on their start_span so users can opt out. (Note it returns a context manager, so Python's with start_span(…): is equivalent to our with_span.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions