Skip to content

SemConv 1.33.0 #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SemConv 1.33.0 #855

wants to merge 2 commits into from

Conversation

bryannaegele
Copy link
Contributor

This is surely a nightmare for some but this version marks DB semantics as stable, so best to get it over with for Ecto before releasing that. Code attributes are also stable now.

Releases should be much easier now thanks to all the work the weaver team did.

Please pay special attention to the new namespaces and acronyms for acceptability. The AZ one not being in Azure is kinda weird tbh but that's the spec. 🤷🏻

Android namespace was excluded in erlang but not elixir. Not sure which way to go on that one so just added it back to erlang for now for completeness.

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.32%. Comparing base (7faf931) to head (6f58bf5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   17.32%   17.32%           
=======================================
  Files          24       24           
  Lines         710      710           
=======================================
  Hits          123      123           
  Misses        587      587           
Flag Coverage Δ
api 17.32% <ø> (ø)
elixir 17.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask
Copy link
Member

trask commented May 14, 2025

The AZ one not being in Azure is kinda weird

are you referring to az.namespace? that was renamed to azure.namespace (and az.namespace was deprecated)

@bryannaegele
Copy link
Contributor Author

Yeah, that was a weird one. I'm guessing we should just add that to the ignored namespaces since it effectively never existed in our releases? Seems like the easiest course of action.

@trask
Copy link
Member

trask commented May 15, 2025

it effectively never existed in our releases

I'm curious why it never existed? az.namespace was around for a while, or are you updating from a pretty old semconv release?

@bryannaegele
Copy link
Contributor Author

From 1.27.0, so almost a year since the last release. I'm on my phone but I think they're new files which would mean we didn't have it before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants