fix: multi-platform build #2400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
force-pushed
the
fix_multiplatform_build
branch
from
e583d53 to
d201d5a
Compare
|
MrAlias
requested changes
Jun 16, 2025
| @@ -3,6 +3,7 @@ | |||
| # must-have toplevel files | |||
| !/go.sum | |||
| !/go.mod | |||
| !/Makefile | |||
There was a problem hiding this comment.
Adding this makes the docker cache invalidated on changes to the makefile. That should not happen as it does not affect the built binary.
| RUN --mount=type=cache,target=/root/.cache/go-build \ | ||
| --mount=type=cache,target=/go/pkg \ | ||
| GOARCH=$TARGETARCH \ |
There was a problem hiding this comment.
Why not set this in the build pipeline?
+1 to this approach as it will persist the value during runtime. |
|
|
Superseded by #2411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2399