fix: ignore modules with (devel) versions
#2401
Open
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
commented
Jun 3, 2025
MrAlias
reviewed
Jun 17, 2025
MrAlias
reviewed
Jun 20, 2025
| @@ -133,10 +133,18 @@ func goDevVer(raw string) (*semver.Version, error) { | |||
| return nil, errors.New("non-devel version") | |||
| } | |||
|
|
|||
| func findModules(goVer *semver.Version, deps []*debug.Module) (map[string]*semver.Version, error) { | |||
| func findModules( | |||
| logger *slog.Logger, | |||
There was a problem hiding this comment.
Adding a logger parameter to this just to log a message that can be conveyed as an error does not seem like a good design. Can we just return a defined error type here and have the caller with a logger log it as needed instead?
|
Alternate solution: #2437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2388
see #2388 (comment)