Skip to content

Simplify auto spotless workflow #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

trask
Copy link
Member

@trask trask commented May 28, 2025

Also should fix the edge case where PR is coming from main branch on fork: #1855 (comment)

The problem before was that there was already a main branch checked out locally, but now it checks out remote branch directly.

@trask trask requested a review from a team as a code owner May 28, 2025 22:02
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague memory that as a maintainer I was not allowed to push into the main branch of the fork. If that is true then probably this won't work anyway.

@trask
Copy link
Member Author

trask commented May 29, 2025

I have a vague memory that as a maintainer I was not allowed to push into the main branch of the fork. If that is true then probably this won't work anyway.

I just tested pushing to #1855 and seems to work: #1855 (comment)

@trask trask added this pull request to the merge queue May 29, 2025
Merged via the queue into open-telemetry:main with commit f4ff5f4 May 29, 2025
19 checks passed
@trask trask deleted the simplify-auto-workflow branch May 29, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants