Add readme for spark instrumentation #14055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
atoulme
approved these changes
Jun 17, 2025
jaydeluca
approved these changes
Jun 17, 2025
trask
approved these changes
Jun 17, 2025
Comment on lines
+7
to
+8
|
|
||
| This instrumentation is NOT for Apache Spark. |
There was a problem hiding this comment.
seems pretty well covered above already?
Suggested change
| This instrumentation is NOT for Apache Spark. |
There was a problem hiding this comment.
I wanted it to be very clear. :)
laurit
reviewed
Jun 18, 2025
|
|
||
| This instrumentation is NOT for Apache Spark. | ||
|
|
||
| The instrumentation here facilitates tracing by generating HTTP SERVER spans. |
There was a problem hiding this comment.
This instrumentation does not generate any spans.
There was a problem hiding this comment.
ah right, it looks similar to the Avaje-jex-3.0 instrumentation, so maybe the description could instead be
Suggested change
| The instrumentation here facilitates tracing by generating HTTP SERVER spans. | |
| This instrumentation does not emit telemetry on its own. Instead, it extracts the HTTP route and attaches it to SERVER spans and HTTP server metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People see "spark" and now think it means "Apache Spark". Adding this readme in hopes of clarifying that for some confused users.