-
Notifications
You must be signed in to change notification settings - Fork 925
OTEP: Extending attributes to support complex values #4485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+311
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complex attributes: first round of feedback and clean up
pellared
reviewed
Apr 22, 2025
pellared
reviewed
Apr 22, 2025
trask
reviewed
Apr 22, 2025
Clarify metrics and cleanup
jack-berg
reviewed
Apr 22, 2025
pellared
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM. There are still some things that would be good to have clarified.
pellared
reviewed
Apr 23, 2025
trask
reviewed
Apr 23, 2025
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
MrAlias
reviewed
Jun 24, 2025
MrAlias
reviewed
Jun 24, 2025
pellared
reviewed
Jun 24, 2025
hdost
reviewed
Jun 26, 2025
jsuereth
reviewed
Jul 5, 2025
jsuereth
reviewed
Jul 5, 2025
jsuereth
reviewed
Jul 5, 2025
lmolkova
commented
Jul 8, 2025
lmolkova
commented
Jul 8, 2025
lmolkova
commented
Jul 8, 2025
…ents to implementations that allow using complex attrs on metrics, resources, entities, instr scope
jsuereth
approved these changes
Jul 14, 2025
austinlparker
approved these changes
Jul 14, 2025
reyang
approved these changes
Jul 15, 2025
MrAlias
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4468, #4414
This OTEP suggests a path forward on how to support complex attributes. It proposes to:
Having experimental phase for complex attributes limits the impact of this change and gives backends a graceful period to update.