-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs(lambda): update handler docs #7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(lambda): update handler docs #7048
Conversation
also the ones in japanese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @duncanista, thanks very much for keeping the docs updated! We appreciate the initiative.
I've made a couple copy edit suggestions, and we should also get the @open-telemetry/lambda-extension-approvers to sign off.
Finally, while we appreciate the effort, please revert the changes to the localized version of this page. To keep track of drift, we have a more involved process for updating localized pages, and it's best to leave it to the localization teams.
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. I suggest we hold off on merging till after open-telemetry/opentelemetry-lambda#1837 is released though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes needed, I'm just using this to block merging until we're ready.
What?
Updates docs to use the same handler for AWS Lambda instrumentation.
Notes
Requires open-telemetry/opentelemetry-lambda#1837 to be merged first.