Skip to content

#92: Techdebt/testing infrastructure improvements #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mjstelly
Copy link

@mjstelly mjstelly commented Jun 16, 2025

Summary

This PR addresses the beginning of a solution for issue #92.

Test Plan

The ACTION_PLAN.md file, found in the root directory, itemizes the work plan for this solution.

What are the steps to reproduce?

Nothing to reproduce.

Checklist

What was performed:
Fixed Issues:

  • ✅ Jest testMatch pattern syntax error (removed extra >)
  • ✅ Standardized test file naming (.test.tsx → .spec.tsx)
  • ✅ Organized test files in proper tests/ directory structure
  • ✅ Updated import paths and snapshots
  • ✅ Verified all 4 test suites pass (18 tests total)
  • I tested this thoroughly
  • I added the documentation in README.md (if needed)
  • [ ]

- Fixed testMatch pattern in jest.config.js (removed extra '>' character)
- Renamed Select.test.tsx to Select.spec.tsx for consistency
- Moved Select test to proper __tests__ directory structure
- Updated import path and snapshot for relocated test file
- All 4 test suites now pass with 18 tests total
@mjstelly
Copy link
Author

AS mentioned, this is phase 1 of the action plan. If you approve of this PR and the associated plan, I'll proceed with the plan execution.

- Re-added ACTION_PLAN.md that was lost during branch cleanup
- Contains comprehensive 5-phase testing improvement strategy
- Documents 13 child branches with specific tasks and success metrics
@mjstelly mjstelly force-pushed the techdebt/testing-infrastructure-improvements branch from 77238cb to 0743d5a Compare June 16, 2025 12:34
@pvinis
Copy link
Member

pvinis commented Jun 16, 2025

we basically need tests for the version selection, thats all. #92 (comment). if you're up for that, do some of this? no need for extra files.

@mjstelly
Copy link
Author

we basically need tests for the version selection, thats all. #92 (comment). if you're up for that, do some of this? no need for extra files.

This first PR is organizational in nature. It lays the groundwork for further planned improvements and fixes a syntax error in the config file. The files are necessary for this work to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants