Fix tests with rpy2 3.6 #40175
Merged
Fix tests with rpy2 3.6 #40175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpy2 3.6 is quite chatty and the warnings break a few tests
|
There are some additional warnings emitted by rpy2 itself, fixed upstream in rpy2/rpy2@316340b |
|
I have not seen those yet. I do not have as much time as I used to to get on the edge. But I will get back to you ASAP. Probably deal with cython 3.1+ first. |
|
Taking the liberty to set this to positive review myself. This is a harmless change with zero risk of regressions and there doesn't seem to be many people around who can test it (CI doesn't even install rpy2) |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 27, 2025
sagemathgh-40175: Fix tests with rpy2 3.6 rpy2 3.6 is quite chatty and the warnings break a few tests URL: sagemath#40175 Reported by: Antonio Rojas Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpy2 3.6 is quite chatty and the warnings break a few tests