Skip to content

minor fixes in a pyx file in quadratic_forms #40334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2025
Merged

minor fixes in a pyx file in quadratic_forms #40334

merged 2 commits into from
Jul 6, 2025
+33 −30

Conversation

fchapoton
Copy link
Contributor

  • using python style for the for loops
  • adding a reference to the master reference file, and cleaning a bit around there

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 382146d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

dcoudert
dcoudert approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci.

LGTM.

@vbraun vbraun merged commit 4ba400e into sagemath:develop Jul 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: quadratic forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun