⚒️ Resolves lighthouse issue (#398)

* Updates dependencies

* Fixes tap target to resolve lighthouse

* Merge conflicts

Author: tatianamac

11ty/_includes/components/definition-content.njk

@@ -1,10 +1,7 @@
 {% macro renderAltWords(words, labels) %}
   {%- if words | isArray -%}
     {# Array #}
-    <ul
-      class="list-semicolon"
-      {% if labels %}aria-labelledby="{{ labels | join(' ') }}"{% endif %}
-    >
+    <ul class="list-semicolon" {% if labels %} aria-labelledby="{{ labels | join(' ') }}" {% endif %}>
       {%- for word in words -%}
         <li>
           {{ word | linkIfExistsInCollection(collections.definedWords) | safe }}
@@ -15,8 +12,7 @@
     {# Object #}
     {# With class="", the list loses padding via the CSS reset style. #}
     {# For multi-level category support, we may want an actual class. #}
-    <ul class="">
-      {%- for category, list in words -%}
+      <ul class=""> {%- for category, list in words -%}
         <li>
           {% set categoryId = ("alt-words-" + category) | replace(' ', '-') %}
           <strong id="{{ categoryId }}">{{ category }}</strong>
@@ -26,7 +22,6 @@
     </ul>
   {%- endif -%}
 {% endmacro %}
-
 <section class="definition-content">
   <section class="definition-content__content">
     {{ content | safe }}
@@ -40,13 +35,13 @@
   {%- if reading -%}
     <section class="definition-content__content">
       <h2 id="further-reading">Further Reading</h2>
-      <ul class="list-semicolon" aria-labelledby="further-reading">
+      <ul class="list-no-bullets" aria-labelledby="further-reading">
         {% for link in reading %}
           <li>
-            <a href="{{link.href}}">{{ link.text }}</a>
+            <a href="{{ link.href }}">{{ link.text }}</a>
           </li>
         {% endfor %}
       </ul>
     </section>
   {% endif %}
-</section>
+</section>

assets/css/components/_lists.scss

@@ -1,4 +1,5 @@
-ol, dl {
+ol,
+dl {
   margin: 0;
   padding: 0 0 0 1em;
 }
@@ -25,18 +26,10 @@ dt {
   font-weight: $bold;
 }
 
-.list-semicolon {
+.list-no-bullets {
   list-style: none;
   margin: 0;
   padding: 0;
-
-  & > li {
-    display: inline;
-
-    &:not(:last-child)::after {
-      content: '; ';
-    }
-  }
 }
 
 .list-default {

lighthouserc.js

@@ -1,16 +1,16 @@
 module.exports = {
   ci: {
     upload: {
-      target: 'temporary-public-storage',
+      target: 'temporary-public-storage'
     },
     assert: {
-      preset: "lighthouse:no-pwa",
+      preset: 'lighthouse:no-pwa',
       assertions: {
-        "font-display": "off",
-        "uses-rel-preconnect": "off",
-        "render-blocking-resources": "off",
-        "uses-long-cache-ttl": "off"
+        'font-display': 'off',
+        'uses-rel-preconnect': 'off',
+        'render-blocking-resources': 'off',
+        'uses-long-cache-ttl': 'off'
       }
     }
-  },
+  }
 };