use normal completions in ACs passed to CreateIteratorFromClosure when possible #3602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
added
editorial change
completion records
|
I don't like that we have this degree of freedom. We should pick one and stick with it, and ensure the machinery only supports that kind. I'll prepare some PRs so we can see what the machinery would look like in each case. |
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateIteratorFromClosure passes the AC to GeneratorStart which treats any normal completion return value the same as a
ReturnCompletion(*undefined*). It seems better to me to useNormalCompletion(~unused~)in these locations and only return a return completion if we want to use a value other than*undefined*.