Editorial: Replace [[DFSIndex]] with a local variable #3625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Jun 20, 2025
bakkot
reviewed
Jun 25, 2025
bakkot
approved these changes
Jun 25, 2025
nicolo-ribaudo
force-pushed
the
remove-dfsindex
branch
from
f3de65d to
e96fa6b
Compare
linusg
approved these changes
Jun 26, 2025
michaelficarra
approved these changes
Jun 26, 2025
michaelficarra
added
editorial change
ready to merge
The [[DFSIndex]] field of module records is only ever read by `InnerModule*` algorithms, and only on the same module that the algorithm is called on. There is no need to have it as a field on the module record, and removing it helps by having on less piece of potentially mutable state to keep track of while reading the algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [[DFSIndex]] field of module records is only ever read by
InnerModule*algorithms, and only on the same module that the algorithm is called on.There is no need to have it as a field on the module record, and removing it helps by having on less piece of potentially mutable state to keep track of while reading the algorithms.