[feat] LambdaTest Credential Detector #4208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabeelalam
reviewed
Jun 20, 2025
| // Keywords are used for efficiently pre-filtering chunks. | ||
| // Use identifiers in the secret preferably, or the provider name. | ||
| func (s Scanner) Keywords() []string { | ||
| return []string{"lambdatest", "LT_"} |
There was a problem hiding this comment.
LT_ might yield a significant amount of false matches, a lot of unnecessary chunks inputs might get filtered in.
nabeelalam
reviewed
Jun 20, 2025
|
|
||
| s1 := detectors.Result{ | ||
| DetectorType: detectorspb.DetectorType_LambdaTest, | ||
| Raw: []byte(fmt.Sprintf("%s:%s", usernameMatch, accessKeyMatch)), |
There was a problem hiding this comment.
Could you add a value for RawV2 as well? It should be the same value
nabeelalam
reviewed
Jun 20, 2025
|
|
||
| isVerified, extraData, verificationErr := verifyMatch(ctx, client, usernameMatch, accessKeyMatch) | ||
| s1.Verified = isVerified | ||
| s1.ExtraData = extraData |
There was a problem hiding this comment.
There doesn't seem to be any extraData being returned by verifyMatch.
We can also remove map[string]string from the return types and update the return statements.
nabeelalam
requested changes
Jun 20, 2025
| return true, nil, nil | ||
| case http.StatusUnauthorized: | ||
| // The secret is determinately not verified (nothing to do) | ||
| return false, nil, fmt.Errorf("access key not present in db or invalid") |
There was a problem hiding this comment.
In cases where we determinately unverify credentials, we should return a nil error, since errors imply issues in the verification process or indeterminate results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
LambdaTest is a cloud-based cross-browser testing platform that allows developers to test their web applications across various browsers and devices. This relates to issue : #4181
This feature enables detection of username and access key of LambdaTest based on its pattern and verifies the credentials as well by sending a request to the endpoint.
Checklist:
make test-community)?make lintthis requires golangci-lint)?