Skip to content

feat: allow changing Docker image for scan job #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krzysztof-clari
Copy link

Description:

Allows changing Docker image used for the scan job, this is useful if the Docker images should be pulled from a different place than the GitHub Container Registry. Such situations usually occur with air-gapped systems or places where Docker registry access is restricted.

Fixes #4241.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?
    • Not really applicable as the change does not touch Go code, but no, fails with:
❯ make lint
golangci-lint run --enable bodyclose --enable copyloopvar --enable misspell --out-format=colored-line-number --timeout 10m
Error: unknown flag: --out-format
Failed executing command with error: unknown flag: --out-format
make: *** [lint] Error 3

My version information:

❯ golangci-lint --version
golangci-lint has version 2.1.6 built with go1.24.2 from eabc263 on 2025-05-04T15:36:41Z

@krzysztof-clari krzysztof-clari requested a review from a team as a code owner June 17, 2025 17:31
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

Allows changing Docker image used for the scan job, this is useful if
the Docker images should be pulled from a different place than the
GitHub Container Registry. Such situations usually occur with air-gapped
systems or places where Docker registry access is restricted.
@krzysztof-clari krzysztof-clari force-pushed the feature/allow-changing-docker-image branch from d5db5f8 to ec59cac Compare July 14, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing used Docker image for teh GitHub Action
2 participants