Add OpenVSX detector #4243
Open
Add OpenVSX detector #4243
+474
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shahzadhaider1
requested changes
Jun 18, 2025
| } | ||
|
|
||
| s1 := detectors.Result{ | ||
| DetectorType: detectorspb.DetectorType_Generic, // Using Generic since VSX is not explicitly listed |
There was a problem hiding this comment.
We can create a new detector type. Please refer to this: Adding a New Detector
|
@Kiblyn11 Thanks for your contribution! I’ve done an initial review; great work so far. I’ve left some feedback for minor improvements. I’ll do a thorough review once the updates are in. |
|
@shahzadhaider1 Thanks for your initial review. I have to admit I hacked this at first to check some assumptions without looking at contributing guides. I updated the detector type to be specific. |
nabeelalam
reviewed
Jun 20, 2025
Comment on lines
40
to
45
| return []string{ | ||
| "VSX", "VSIX", "OPENVSX", | ||
| "EXTENSION", "PUBLISHER", | ||
| "ovsx", "OVSX_TOKEN", "OVSX_ACCESS_TOKEN", | ||
| "OVSX_PAT", "OVSX_KEY", | ||
| } |
There was a problem hiding this comment.
VSX is a substring in OPENVSX, OVSX, etc. so strings containing it are not required. Keywords are case-insensitive as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a detector for OpenVSX tokens used by OpenVSX registry: https://open-vsx.org/
It use an available API endpoint on a legitimate namespace and look for permission issue error which means the token exist and is valid.
Checklist:
make test-community)?make lintthis requires golangci-lint)?