Skip to content

Fixed jira detector invalid domain issue #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Jun 20, 2025

Description:

Fixes: #4245
This PR adds a check for JIRA to decode the body in case of 200 OK response during verification to avoid invalid responses from the invalid domains.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner June 20, 2025 07:12
Copy link
Contributor

@thiggy1342 thiggy1342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

Copy link
Contributor

@nabeelalam nabeelalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kashifkhan0771 kashifkhan0771 merged commit 20e0233 into trufflesecurity:main Jun 23, 2025
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the fix/oss-237 branch June 23, 2025 08:00
@kashifkhan0771 kashifkhan0771 self-assigned this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add body check for Jira detector
3 participants